Repository navigation
Update countries geojson file to use ONS BFE - #480
Open
davidjamesstone wants to merge 1 commit into
Open
davidjamesstone wants to merge 1 commit into
davidjamesstone wants to merge 1 commit into
Conversation
…rside validation and simplified for use on the client - Added new geojson file for countries data. - Introduced a CountryMap object to map country names to their respective identifiers. - Updated GeospatialCountriesQuery typedef to use keyof CountryMap for omit and only properties.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Update countries geojson file to use ONS BFE reduced to 5dp for server-side validation and simplified for use on the client
Proposed change
Fixes two issues, first that locations near the coast could be deemed outside the country due to clipping. This has been remedied by using the full BFE file for server-side validation.
The second issue is that inlets and rivers could be deemed outside the country. This is solved by moving the ONS BFE that clips to the mean low water mark. The following point on the Thames was previously deemed outside England.
This is now solved as the Thames is clipped:
Jira ticket: https://eaflood.atlassian.net/browse/DF-1508
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).